genivi-audio-manager@lists.genivi.org

development list for the AudioManager

View all threads

Pull-requests for GenIVI AudioManager

KM
Koch, Martin (ESE GmbH; ADITG/ESM)
Fri, Dec 6, 2019 8:16 AM

Hello all,

I am new to this list and at the same time took over

  •      moderation responsibility for this list
    
  •      maintenance responsibility for the audiomanagerplugins repository
    

We at ADIT made significant changes to the generic controller plugin (can be considered as new major version). Some of these changes required changes also in the daemon code.

So I started my activities with 3 trivial pull requests for the daemon. These are:

  1.   Drop an accidentally pushed backup file, which is present in repository since 2016. In our environment its presence prevents successful generation of documentation.
    
  2.   add a documentation to the global namespace 'am'. The presence of this documentation enables doxygen (as of version 1.8.11) to resolve @ref links not only for classes, but also for documented enums, typedefs and defines.
    
  3.   fix implementation of CAmDatabaseHandlerMap::removeMainConnectionDB(). Changed first parameter for DB_COND_UPDATE() to ID instead of connection state &    move erase() behind conditional block
    

and can be found at https://github.com/GENIVI/AudioManager/pulls. Accidentally (beginners fault), 1. is also contained in 2. and 3.

If you don't have any objections, I will merge these requests by next Friday, 2019-12-13. After that I intend to continue creating pull requests for other changes as well.

Best regards

Martin Koch
Advanced Driver Information Technology GmbH
Engineering Software Multimedia (ESM)
Robert-Bosch-Str. 200
31139 Hildesheim
Germany
Tel. +49 5121 49 6954
Fax +49 5121 49 6999
mkoch@de.adit-jv.com
www.adit-jv.com
ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car Multimedia GmbH and DENSO Corporation
Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438
Geschäftsführung: Wilhelm Grabow, Ken Yaguchi
Data protection information: We use your contact information and e-mail communication to process your inquiry and for internal and possibly tax documentation purposes. Your information will only be passed on to third parties if this is necessary to carry out your request or if we are legally obliged to do so.

Hello all, I am new to this list and at the same time took over - moderation responsibility for this list - maintenance responsibility for the audiomanagerplugins repository We at ADIT made significant changes to the generic controller plugin (can be considered as new major version). Some of these changes required changes also in the daemon code. So I started my activities with 3 trivial pull requests for the daemon. These are: 1. Drop an accidentally pushed backup file, which is present in repository since 2016. In our environment its presence prevents successful generation of documentation. 2. add a documentation to the global namespace 'am'. The presence of this documentation enables doxygen (as of version 1.8.11) to resolve @ref links not only for classes, but also for documented enums, typedefs and defines. 3. fix implementation of CAmDatabaseHandlerMap::removeMainConnectionDB(). Changed first parameter for DB_COND_UPDATE() to ID instead of connection state & move erase() behind conditional block and can be found at https://github.com/GENIVI/AudioManager/pulls. Accidentally (beginners fault), 1. is also contained in 2. and 3. If you don't have any objections, I will merge these requests by next Friday, 2019-12-13. After that I intend to continue creating pull requests for other changes as well. Best regards Martin Koch Advanced Driver Information Technology GmbH Engineering Software Multimedia (ESM) Robert-Bosch-Str. 200 31139 Hildesheim Germany Tel. +49 5121 49 6954 Fax +49 5121 49 6999 mkoch@de.adit-jv.com www.adit-jv.com ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car Multimedia GmbH and DENSO Corporation Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438 Geschäftsführung: Wilhelm Grabow, Ken Yaguchi Data protection information: We use your contact information and e-mail communication to process your inquiry and for internal and possibly tax documentation purposes. Your information will only be passed on to third parties if this is necessary to carry out your request or if we are legally obliged to do so.