[PATCH] ivi-controller: do not iterate over empty list in send_surface_add_event

Natsume, Wataru (ADITJ/SWG) wnatsume at jp.adit-jv.com
Wed May 18 06:06:55 EDT 2016


Hello Potrola-san,

Thank you for your contribution. As you pointed, the empty list should be checked.
In your patch, break looks better than continue because further iteration would not make sense.

In addition, would you recreate your patch in accordance with Genivi rule below? Then your patch would be merged smoothly.
 
https://at.projects.genivi.org/wiki/display/PROJ/How+to+contribute+to+GENIVI

I also found some point might cause crash during this review. Let me issue it in another thread.

Best Regards,
Wataru Natsume

---
Wataru Natsume / 夏目 亘
Advanced Driver Information Technology
Software Group (ADITJ/SWG)
E-mail: wnatsume at jp.adit-jv.com
Tel: +81-(0)566-61-4551 / Extension 551-43644


-----Original Message-----
From: genivi-ivi-layer-management-bounces at lists.genivi.org [mailto:genivi-ivi-layer-management-bounces at lists.genivi.org] On Behalf Of mateuszx.potrola at intel.com
Sent: Monday, May 16, 2016 8:13 PM
To: genivi-ivi-layer-management at lists.genivi.org
Subject: [PATCH] ivi-controller: do not iterate over empty list in send_surface_add_event


Iterating over empty list will modify first value passed to wl_list_for_each, but that won't be valid list entry, which in case of send_surface_add_even leads to crash.
---
 weston-ivi-shell/src/ivi-controller-impl.c | 4 ++++
 1 file changed, 4 insertions(+)

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928


More information about the genivi-ivi-layer-management mailing list