[genivi-dlt] Suggested patch - add cmake support to dlt-viewer

Andersson, Gunnar gunnar.x.andersson at volvocars.com
Sun Oct 16 16:26:06 EDT 2016


Jack,

Shouldn't you patch INSTALL.txt also to add instructions for how to build?
I could only see it describing the qmake method which would be confusing if
cmake files are added everywhere.

Even if it is only something simple like:

mkdir build
cd build
cmake ..
make

Also, if you could, how to handle some corner cases, for example if Qt installation
exists somewhere but that is not described by pkg-config, I'm guessing it won't
be found - can the Qt location be specified with an environment variable?

Nice work otherwise.

- Gunnar

From: genivi-diagnostic-log-and-trace [mailto:genivi-diagnostic-log-and-trace-bounces at mailman1.genivi.org] On Behalf Of Jack.Smith at elektrobit.com
Sent: den 11 oktober 2016 11:18
To: genivi-diagnostic-log-and-trace at mailman1.genivi.org
Subject: [genivi-dlt] Suggested patch - add cmake support to dlt-viewer

Hello,

Attached please find a suggested patch "0545-Add-CMake-support-to-the-project.patch".

This patch adds support for CMake build system to dlt-viewer.

Signed-off-by:   Jack Smith jack.smith at elektrobit.com<mailto:jack.smith at elektrobit.com>

I hope this helps.
Jack


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20161016/33bbda8d/attachment.html>


More information about the genivi-diagnostic-log-and-trace mailing list