[genivi-dlt] Patch moving dlt-daemon from FIFO to UDS (was: Issues with mechanism to change log-level)

Jeremiah Foster jeremiah.foster at pelagicore.com
Wed Oct 5 09:49:14 EDT 2016


On Wed, Oct 5, 2016 at 9:38 AM, Andersson, Gunnar <
gunnar.x.andersson at volvocars.com> wrote:

>
> >On Wed, Oct 5, 2016 at 4:49 AM, Tobias Olausson <
> tobias.olausson at pelagicore.com> wrote:
> >Hi,
> >
> >On 5 October 2016 at 07:17, Lipka, Christoph (ADITJ/SWG) <
> clipka at jp.adit-jv.com> wrote:
>


> >>>@Jeremiah: Might it be possible to handle this as pull request for
> >>>community review in github? I anyhow don’t really like the current
> >>>approach of sending patches to mailing list, since nearly nobody is
> >>>checking patches or gives comments.
> >
> >>I agree, plus it gives much better opportunities to track changes +
> >>discussion together.
> >
> >Absolutely. Let's set up a workflow that works for you folks. :-)
> >
> >For clarity, what do we want to set up?
>
> I think the poster just want your blessing for using PRs instead
> of patches mailed to list...
>
> Where is the "standard" patch submission policy documented, Jeremiah?
>

https://at.projects.genivi.org/wiki/display/PROJ/How+to+contribute+to+GENIVI


> Maybe we just double check that it provides good default recommendations
> but allows for flexibility according to maintainers?
>

​Looks like Agustin added explicit preferences for pull requests in
September.​


>
> >Pull requests for DLT daemon are
> >available here: https://github.com/GENIVI/dlt-daemon/pulls I guess Tobias
> >will have to clone DLT daemon and create a pull request, no? If we do
> >that, shouldn't we take the opportunity to create a new branch?
> >We tend to always use the 'master' branch in GENIVI and that can cause
> >problems sometimes.
>
> Although...each PR is its own branch already, logically speaking.
> You can even pull it from GitHub as a branch.
>
> > Perhaps we start a dev branch or similar?
>
> For what it's worth, a limitation in the GoCD plugin we use for automated
> PR builds means it can only monitor PRs that are provided to master.
> It sucks, but the bug seems open and my skills in understanding GoCD
> internals
> are not up to snuff [1]
>

​Okay. Good to know.​

>
> It's only a concern if we intend to automate building of PRs for that
> particular
> project in go.genivi.org (which of course I recommend, unless you have
> something else set up that everyone can see)
>
> DLT-daemon is being built on go.genivi.org now, since it will be included
> in
> the software dev environment.
>
> >
> >Also, here is the code for the softwarecontainer:
> >https://github.com/Pelagicore/softwarecontainer
> >
> >Cheers,
> >
> >Jeremiah
>
> [1] https://github.com/ashwanthkumar/gocd-build-
> github-pull-requests/issues/66


​Cheers,

Jeremiah​



-- 
Jeremiah C. Foster
GENIVI COMMUNITY MANAGER

Pelagicore AB
Ekelundsgatan 4, 6tr, SE-411 18
Gothenburg, Sweden
M: +1.860.772.9242
jeremiah.foster at pelagicore.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20161005/326524f3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PELAGICORE_RGB_Black_horizontal.png
Type: image/png
Size: 11841 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20161005/326524f3/attachment.png>


More information about the genivi-diagnostic-log-and-trace mailing list