[genivi-dlt] Updates on 2.15 DLT daemon

Andersson, Gunnar gunnar.x.andersson at volvocars.com
Tue May 3 06:36:52 EDT 2016


+1 Thanks for the patches Christian.

I did study them after the split and I had a few thoughts around some issues but 
ran out of time to communicate it.

But some of my concerns really have to do with the code that these patches are 
changing also.  So if I do a more thorough review some time later I could try to 
communicate those things based on the whole code base as it stands after 
applying them, rather than the patches specifically.

Best Regards
- Gunnar


-----Original Message-----
From: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] On Behalf Of Alexander.AW.Wenzel at bmw.de
Sent: den 3 maj 2016 12:19
To: clipka at jp.adit-jv.com; genivi-diagnostic-log-and-trace at lists.genivi.org
Subject: Re: [genivi-dlt] Updates on 2.15 DLT daemon

Hello Christoph,

Thanks for the contribution. All patches are now applied to the master.

Best regards

    Alex

-----Ursprüngliche Nachricht-----
Von: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] Im Auftrag von Lipka, Christoph (ADITJ/SWG)
Gesendet: Freitag, 15. April 2016 09:31
An: genivi-diagnostic-log-and-trace at lists.genivi.org
Betreff: Re: [genivi-dlt] Updates on 2.15 DLT daemon

Hi,

As Gunnar discussed, here the changes again, but split into separated patches.

Please have a look and let me know if any clarification is needed.
Thanks.

Best regards

Christoph Lipka
Software Group (ADITJ/SWG)

Tel. +81-(0)566 61-5124


-----Original Message-----
From: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] On Behalf Of Lipka, Christoph (ADITJ/SWG)
Sent: Friday, April 15, 2016 10:21 AM
To: genivi-diagnostic-log-and-trace at lists.genivi.org
Subject: Re: [genivi-dlt] Updates on 2.15 DLT daemon

Hi Gunnar,

Thanks for your comment. I very appreciate that someone is looking into it in detail. The stuff works for us and is already in practical use, but of course might raise some problems if someone else using it in a different way which was not expected by us.


We though it is a better idea to squash things together to not have a list of ~ 20 commits. But we can also provide the same thinks as list of more separated patches - no problem at all, we have it in place for internal reference.

We will recheck and send the patches again by today.

Best regards

Christoph Lipka
Software Group (ADITJ/SWG)

Tel. +81-(0)566 61-5124





More information about the genivi-diagnostic-log-and-trace mailing list