[genivi-dlt] Multiple patches pushed

Lipka, Christoph (ADITJ/SWG) clipka at jp.adit-jv.com
Fri Jan 29 04:04:52 EST 2016


Hi Lutz,

From our point of view, it need to be reverted (at least the Logstorage related change). I will think about a better description of the WITH_DLT_LOGSTORAGE_CTRL_PROP entry.

Best regards

Christoph Lipka
Software Group (ADITJ/SWG)

Tel. +81-(0)566 61-5124

From: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] On Behalf Of Helwing, Lutz
Sent: Friday, January 29, 2016 6:02 PM
To: genivi-diagnostic-log-and-trace at lists.genivi.org
Subject: Re: [genivi-dlt] Multiple patches pushed

Hi,

meaning i was too quick pushing it? Shall i revert the lines in questions?

Best regards,
Lutz
On 29/01/16 09:56, Lipka, Christoph (ADITJ/SWG) wrote:
Hi Stefan,

It was our intension to have it in the way it was:

if(WITH_DLT_LOGSTORAGE_CTRL_UDEV AND WITH_DLT_LOGSTORAGE_CTRL_PROP)
- set(dlt_logstorage_ctrl_SRCS dlt-logstorage-ctrl.c dlt-logstorage-common.c dlt-logstorage-prop.c dlt-logstorage-udev.c dlt-logstorage-list.c)
elseif(WITH_DLT_LOGSTORAGE_CTRL_PROP)
- set(dlt_logstorage_ctrl_SRCS dlt-logstorage-ctrl.c dlt-logstorage-common.c dlt-logstorage-prop.c dlt-logstorage-list.c)

Maybe we made it not clear enough what that mean. E.g. we use another internal tool instead of udev to handle device connection events. In this case, we only add our dlt-logstorage-prop.c file and everything works fine. Enabling WITH_DLT_LOGSTORAGE_CTRL_PROP without having a dlt-logstorage-prop.c will fail.

Best regards

Christoph Lipka
Software Group (ADITJ/SWG)

Tel. +81-(0)566 61-5124

From: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org<mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org> [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] On Behalf Of Vacek, Stefan
Sent: Friday, January 29, 2016 5:46 PM
To: Helwing, Lutz; genivi-diagnostic-log-and-trace at lists.genivi.org<mailto:genivi-diagnostic-log-and-trace at lists.genivi.org>
Subject: Re: [genivi-dlt] Multiple patches pushed

Hi Lutz,

just a quick feedback. If enabling all options in cmake, log-storage  and core_dump_handler are not buildable. Please find attached a patch which fixes this.

Regards,
Stefan

From: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org<mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org> [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org]<mailto:[mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org]> On Behalf Of Helwing, Lutz
Sent: Thursday, January 28, 2016 4:45 PM
To: genivi-diagnostic-log-and-trace at lists.genivi.org<mailto:genivi-diagnostic-log-and-trace at lists.genivi.org>
Subject: [genivi-dlt] Multiple patches pushed

Hi all,

i have integrated a bunch of patches for DLT Daemon and DLT Viewer today. Please update your local repositories for using them and please get back to me if you find any issues. Thank you very much!

Kind regards,
Lutz
--

Lutz Helwing
Senior Engineer
Telefon

+49 (89) 57096 - 297<tel:+49%287721%294060-422>

Fax

+49 (89) 57096 - 400

lutz_helwing at mentor.com<mailto:lutz_helwing at mentor.com>


[Mentor                                                    Automotive]
Mentor Graphics Development (Deutschland) GmbH
Arnulfstrasse 201
D-80634 München
http://www.mentor.com

Mentor Graphics Development (Deutschland) GmbH
Geschäftsführung: Dean Freed, Walter Vermijs, Shannon Wetzel
Handelsregister: Amtsgericht Freiburg i.Br., HRB 705237
Sitz der Gesellschaft: Peterzeller Straße 8, 78048 Villingen-Schwenningen
USt-Id Nummer: DE268786819

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.






_______________________________________________

genivi-diagnostic-log-and-trace mailing list

genivi-diagnostic-log-and-trace at lists.genivi.org<mailto:genivi-diagnostic-log-and-trace at lists.genivi.org>

https://lists.genivi.org/mailman/listinfo/genivi-diagnostic-log-and-trace

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160129/0f5c17ef/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 7787 bytes
Desc: image001.png
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160129/0f5c17ef/attachment.png>


More information about the genivi-diagnostic-log-and-trace mailing list