[genivi-dlt] [Patch] Start Filetransfer only when client connected and a bugfix

Helwing, Lutz Lutz_Helwing at mentor.com
Fri Feb 19 04:36:35 EST 2016


Hi,

the patches have been integrated into master.

Best regards
Lutz

On 17/02/16 17:17, Helwing, Lutz wrote:
Hi all,

we have made an improvement to the filetransfer mechanism af dlt-system:

0001-dlt-system-filetransfer-waits-for-a-client.patch:

For each file that is supposed to be sent, dlt-system will check if a client is connected to the daemon. If not, it waits and keeps checking once per second, until a client is connected.

Please notice that files will still be compressed and moved to the .tosend subdirectory, regardless of the client connection.

Since it is not necessarily needed anymore the default startup timeout in dlt-system.conf is changed to 0:
"FiletransferTimeStartup = 0"


We have also found a little bug:

0001-Bugfix-dlt-system-filetransfer-crash.patch:

If a file gets written to after it appeared in a folder that is watched by the dlt-system filetransfer thread, the application tries to send this file multiple times, causing dlt-system to crash and generate a core-dump. This patch fixes this by canceling the sending process more gracefully if the file cannot be found.

We consider MALLOC_ASSERT() at this place is wrong for even two reasons:

1. It is confusing because it does not check a malloc failure (this is already done in unique_name() itself)

2. If unique_name() returns NULL for reasons other than a malloc failure the program must not crash with core-dump

If no objections arise these patches will be integrated into master in this Friday.

Cheers,
Lutz

--

Lutz Helwing
Senior Engineer
Telefon

+49 (89) 57096 - 297<tel:+49%287721%294060-422>

Fax

+49 (89) 57096 - 400

<mailto:Oliver_Hartfuss at mentor.com><mailto:lutz_helwing at mentor.com>lutz_helwing at mentor.com<mailto:lutz_helwing at mentor.com>


[Mentor                                                      Automotive]
Mentor Graphics Development (Deutschland) GmbH
Arnulfstrasse 201
D-80634 München
<http://www.mentor.com><http://www.mentor.com>http://www.mentor.com<http://www.mentor.com>

Mentor Graphics Development (Deutschland) GmbH
Geschäftsführung: Dean Freed, Walter Vermijs, Shannon Wetzel
Handelsregister: Amtsgericht Freiburg i.Br., HRB 705237
Sitz der Gesellschaft: Peterzeller Straße 8, 78048 Villingen-Schwenningen
USt-Id Nummer: DE268786819

Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.





_______________________________________________
genivi-diagnostic-log-and-trace mailing list
genivi-diagnostic-log-and-trace at lists.genivi.org<mailto:genivi-diagnostic-log-and-trace at lists.genivi.org>
https://lists.genivi.org/mailman/listinfo/genivi-diagnostic-log-and-trace


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160219/e832097b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ATT00001.png
Type: image/png
Size: 7787 bytes
Desc: ATT00001.png
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160219/e832097b/attachment.png>


More information about the genivi-diagnostic-log-and-trace mailing list