[genivi-dlt] [Patch] Several patchs for Bugfix and improvements

yusuke-sato at apn.alpine.co.jp yusuke-sato at apn.alpine.co.jp
Tue Aug 30 22:36:46 EDT 2016


Hello, Gunner,
thank you for your feedback.

Your point is right. 
I modified the patch 0001.
If you have time, kindly please check my patch again.

And maybe I sent the first e-mail to wrong address 
because my first e-mail has not been recorded to Archives(
https://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace/)...

I sent the message to "genivi-diagnostic-log-and-trace at lists.genivi.org".
Maybe I should have sent the message to 
"genivi-diagnostic-log-and-trace at mailman1.genivi.org".


Therefore, please let me send all the patches(including modified 0001 
patch) again.














Thanks
Best regards.
Yusuke Sato



送信元: "Andersson, Gunnar" <gunnar.x.andersson at volvocars.com>
宛先:   "yusuke-sato at apn.alpine.co.jp" <yusuke-sato at apn.alpine.co.jp>, 
"genivi-diagnostic-log-and-trace at lists.genivi.org" 
<genivi-diagnostic-log-and-trace at lists.genivi.org>
Cc:     "k-takahashi at apn.alpine.co.jp" <k-takahashi at apn.alpine.co.jp>
日付:   2016/08/30 18:31
件名:   RE: [genivi-dlt] [Patch] Several patchs for Bugfix and 
improvements



A really big set of patches.  Thanks for the input.

I only reviewed the first patch, sorry.  It is not something I have time
to do personally very often. :-)

But there's something here that I have seen in this and other
project in many places:

+  if( *buf != NULL )
+  {
+    free(*buf);
+    *buf = NULL;
+  }
+

It is actually not necessary to check if a pointer is NULL before free(). 
The C standard requires free(NULL) to have no effect.  I still agree you 
are doing the right thing to assign NULL to the variable itself, 
especially
in this case when it is an indirect pointer that lives inside of some
other data structure.


- Gunnar 
[1] http://linux.die.net/man/3/free  "If ptr is NULL, no operation is 
performed"
[2] 
http://stackoverflow.com/questions/1912325/checking-for-null-before-calling-free

(and the C standard says the same)

-- 
Gunnar Andersson
Lead Architect, GENIVI Alliance
Infotainment, Volvo Car Corporation

-----Original Message-----
From: genivi-diagnostic-log-and-trace [
mailto:genivi-diagnostic-log-and-trace-bounces at mailman1.genivi.org] On 
Behalf Of yusuke-sato at apn.alpine.co.jp
Sent: den 30 augusti 2016 11:03
To: genivi-diagnostic-log-and-trace at lists.genivi.org
Cc: k-takahashi at apn.alpine.co.jp
Subject: [genivi-dlt] [Patch] Several patchs for Bugfix and improvements

Hello, Alex & mailing List listeners,

please find attached patches for bugfix and improvements.
I hope some of these patches helps you.

Short description of patches:

0001: 
Fix memory leak issue in dlt-dbus.

0002:
Fix file name broken issue then file is transferred on 64 bit OS.

0003:
Accelerate file transfer speed in dlt-system

0004:
Fix segmentation fault issue in checking buffer usage.

0005:
Add debug log for file transfer feature of dlt-system

0006:
Fix the issue that handle of /tmp/dlt (daemon FIFO) never reset if 
dlt-daemon is killed

0007:
Add configuration of daemon FIFO size

0008:
Add configuration of option of Get Log Info response during context 
registration.
If we change the option in dlt.conf, we can reduce unnecessary context 
information.
Option value is as follows.
# Apid and Ctid Only = 3, with LogLevel = 4, with TraceStatus = 5, with LL 

and TS = 6, with LL, TS, and Description = 7 

0009:
Fix the issue that dlt-daemon overwrites ECU ID even if user log message 
already has the ECU ID that is not default value

0010:
Fix the issue that memory for context description is not freed.


Any feedback is very appreciated.














Thanks
Best regards.
Yusuke Sato
--------------------------------------------------------------------------
ATTENTION:This e-mail and any files transmitted with it are the property 
of 
Alpine Electronics, Inc and/or its affiliates, may be privileged and/or 
confidential, and are intended solely for the use of the individual or 
entity 
to whom this e-mail is addressed. If you are not one of the named 
recipients 
or otherwise have reason to believe that you have received this e-mail in 
error, please notify the sender and delete this message immediately from 
your
computer. Any other use, retention, dissemination, forwarding, printing or 

copying of this e-mail is strictly prohibited.

注意:このEメールおよび添付ファイルはアルパイン株式会社および関連子会社の
資産であり、法的特権を持つ情報および秘密情報を含んでいる可能性があります。
また、宛先とした特定の個人もしくは団体、あるいは、それらが指定する人によっ
て
のみ、読まれることを意図しています。もし、あなたがこのEメールの意図された
受信者でないなら、または、誤って送信されたものを受領したと思われる場合は、
速やかに送信者へ通知の上、このEメールを削除してください。また、他の目的へ
の
利用、配布、転送、印刷、コピーは固く禁止されています。
--------------------------------------------------------------------------


--------------------------------------------------------------------------
ATTENTION:This e-mail and any files transmitted with it are the property of 
Alpine Electronics, Inc and/or its affiliates, may be privileged and/or 
confidential, and are intended solely for the use of the individual or entity 
to whom this e-mail is addressed. If you are not one of the named recipients 
or otherwise have reason to believe that you have received this e-mail in 
error, please notify the sender and delete this message immediately from your
computer. Any other use, retention, dissemination, forwarding, printing or 
copying of this e-mail is strictly prohibited.

注意:このEメールおよび添付ファイルはアルパイン株式会社および関連子会社の
資産であり、法的特権を持つ情報および秘密情報を含んでいる可能性があります。
また、宛先とした特定の個人もしくは団体、あるいは、それらが指定する人によって
のみ、読まれることを意図しています。もし、あなたがこのEメールの意図された
受信者でないなら、または、誤って送信されたものを受領したと思われる場合は、
速やかに送信者へ通知の上、このEメールを削除してください。また、他の目的への
利用、配布、転送、印刷、コピーは固く禁止されています。
--------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix_Memory_leak_issue_in_dlt-dbus.patch
Type: application/octet-stream
Size: 970 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix_File_name_is_broken_when_file_is_transferred_on_64bit.patch
Type: application/octet-stream
Size: 7689 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix_File_Transfer_acceleration.patch
Type: application/octet-stream
Size: 1105 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Fix_Segfault_in_checking_buffer_usage.patch
Type: application/octet-stream
Size: 1245 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add_Debug_log_for_file_transfer_feature_of_dlt-system.patch
Type: application/octet-stream
Size: 1242 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Fix_Handle_of_daemon_FIFO_never_reset_if_dlt-daemon_is_killed.patch
Type: application/octet-stream
Size: 1121 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Add_Configuration_of_daemon_FIFO_size.patch
Type: application/octet-stream
Size: 4185 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0006.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add_Configuration_of_option_of_get_log_info_response_during.patch
Type: application/octet-stream
Size: 3884 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0007.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Fix_dlt-daemon_overwrites_ECU_ID_even_if_user_log_message.patch
Type: application/octet-stream
Size: 1653 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0008.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Fix_Memory_for_context_description_is_not_freed.patch
Type: application/octet-stream
Size: 1642 bytes
Desc: not available
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160831/3c139635/attachment-0009.patch>


More information about the genivi-diagnostic-log-and-trace mailing list