[genivi-dlt] Search Text Prediction feature Patch

Vivek Pandey Vivek.Pandey at kpit.com
Tue Aug 9 03:57:37 EDT 2016


Hello Alexander,


Thanks for the information. I will look into this issue and will reproduce it in my side, and will reply till tomorrow about when I am going to give the next patch for the same.


Regards,

Vivek

________________________________
From: Alexander.AW.Wenzel at bmw.de <Alexander.AW.Wenzel at bmw.de>
Sent: Tuesday, August 9, 2016 1:03 PM
To: Vivek Pandey
Cc: genivi-diagnostic-log-and-trace at lists.genivi.org
Subject: AW: Search Text Prediction feature Patch

Hello Vivek,

We found an issue in your Patch.

The DLT Viewer crashes in some circumstances.

To reproduce the crash I have done the following:


1)      Search for "123" in the toolbar, then press return

2)      Seach for "1", then press return + another key e.g. "#" in parallel

3)      When Completer window was open, viewer crashes

We get a null pointer exception in QCoreApplication::notifyInternal(QObject *, QEvent *)

It looks like these lines causes the issue:

void MainWindow::on_action_FindNext()
+{
+    if(!searchTextbox->text().isEmpty() && !list.contains(searchTextbox->text()))
+       {
+           list.append(searchTextbox->text());
+       }
+    newCompleter = new QCompleter(list, this);
+    searchTextbox->setCompleter(newCompleter);
+    newCompleter->setCaseSensitivity(Qt::CaseInsensitive);
+}

If I call setCompleter only once, it works. Also we will get a memory leak, because the memory for newCompleter is not freed.

Solution would be only create and set the completer once and us an abstract model instead of the StringList.
Looks like Qt does not provide a function to update the StringList.

Can you provide a patch for this issue? If not I have to remove the Completer feature.

Best regards

    Alex

--
BMW Group
Alexander Wenzel
Architect. Connected Drive, I and C Syst.

Postanschrift:
80788 München

Tel: +49-89-382-54199
Mail: alexander.aw.wenzel at bmw.de<mailto:alexander.aw.wenzel at bmw.de>
Web: http://www.bmwgroup.com/
--------------------------------------------------------------------
Bayerische Motoren Werke Aktiengesellschaft
Vorstand: Harald Krüger (Vorsitzender),
Milagros Caiña Carreiro-Andree, Klaus Draeger,
Friedrich Eichiner, Klaus Fröhlich, Ian Robertson,
Peter Schwarzenbauer, Oliver Zipse.
Vorsitzender des Aufsichtsrats: Norbert Reithofer
Sitz und Registergericht: München HRB 42243
--------------------------------------------------------------------
Von: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] Im Auftrag von Vivek Pandey
Gesendet: Mittwoch, 9. Dezember 2015 13:40
An: genivi-diagnostic-log-and-trace at lists.genivi.org
Betreff: [genivi-dlt] Search Text Prediction feature Patch


Hello All,



This patch adds a DropDown menu to DLT search TextBox.



In a particular session, if a user repeats an input in search TextBox, a suggestion list will be provided to user from which user can select an appropriate input for search as per choice.

User can switch inside the suggestion list, using UP and DOWN arrow keys as well as with a mouse and can select a search text with ENTER or RETURN keys as well as with mouse click on Search Icon.



Regards,

  Vivek


This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.
This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.genivi.org/pipermail/genivi-diagnostic-log-and-trace_lists.genivi.org/attachments/20160809/168b6206/attachment.html>


More information about the genivi-diagnostic-log-and-trace mailing list