[genivi-dlt] Updates on 2.15 DLT daemon

Andersson, Gunnar gunnar.x.andersson at volvocars.com
Thu Apr 14 04:45:16 EDT 2016


Hi Christoph

> If you have any comments or questions, please let me know.
>

This looks like great stuff.  But why do you squash so many different
changes together?

First thing I noticed browsing patch 1 was:  Introducing long options
 - a really nice little thing, but that change is not mentioned in the 
commit comment at all.

A separate commit would make it difficult to forget to mention it.

Patch 3: dlt-daemon: Connection handling improvements and other updates

 "... and other updates?"

Bugfixes are in there too - good stuff!  But sometimes that introduces 
new bugs -  it can be tricky. So keeping those commits separate really 
help in tracking down regressions with bisect etc.

Finally it's about the review process.  It's hard enough to get volunteers
and at least I get overwhelmed to review it all....  What if someone only 
has time (or competence) to review one of the changes - It would be nice to 
be able to sign off on that commit.   At least I don't want to sign off on the 
really big commit if I've only studied part of it in detail.

If this is the only way you can send because of lack of time then thanks - it's 
still great to get this functionality and bugfixes, but it would be even better 
if different issues are separated in different commits, in my opinion.

My 5c,

Best Regards
- Gunnar

> From: genivi-diagnostic-log-and-trace-bounces at lists.genivi.org
> [mailto:genivi-diagnostic-log-and-trace-bounces at lists.genivi.org] On Behalf
> Of Lipka, Christoph (ADITJ/SWG) Sent: den 14 april 2016 09:58 To:
> genivi-diagnostic-log-and-trace at lists.genivi.org Subject: [genivi-dlt]
> Updates on 2.15 DLT daemon
>
> Dear all,
>
> Attached are a couple of updates we would like to share with you. The
> commit messages contain (hopefully) enough information to understand the
> changes.
>
> 0001-Offlinelogstorage-Functionality-improvements.patch
> 0002-MultiNode-Functionality-improvements.patch
> 0003-dlt-daemon-Connection-handling-improvements-and-othe.patch
> 0004-CommonControl-dlt-control-application-improvements.patch
> 0005-Offline-trace-Make-search-more-precise.patch
> 0006-DLT_PTR-User-macro-to-print-pointers.patch
>
> If you have any comments or questions, please let me know.
>
> Best regards
>
> Christoph Lipka Advanced Driver Information Technology Software Group
> (ADITJ/SWG) 1-1 Showa-cho, Kariya-shi Aichi-ken 448-8661, Japan Tel.
> +81-(0)566 61-5124 Fax +81-(0)566 25-4774 clipka at jp.adit-jv.com
>
> ADIT is joint venture company of DENSO Corporation and Bosch GmbH
>
>



More information about the genivi-diagnostic-log-and-trace mailing list